From: Jeff Garzik <jgarzik@pobox.com>
To: torvalds@osdl.org
Cc: len.brown@intel.com, andrew.grover@intel.com,
zwane@linuxpower.ca, linux-kernel@vger.kernel.org
Subject: [PATCH] 'noapic' already handled elsewhere
Date: Thu, 21 Aug 2003 12:14:36 -0400 [thread overview]
Message-ID: <20030821161436.GA15610@gtf.org> (raw)
I sent a previous patch to s/LOCAL_APIC/IO_APIC/, as Zwane noticed
my first patch needed that. In that patch, I commented __setup()
would be better.
Well... line 718 of arch/i386/kernel/io_apic.c _already_ handles this
case, using __setup() properly.
Word of warning... patch only compile tested, but seems obvious from
looking at io_apic.c.
BTW, why isn't ACPI using __setup() as well? I don't see that ACPI
needs to patch arch/i386/kernel/setup.c at all.
===== arch/i386/kernel/setup.c 1.94 vs edited =====
--- 1.94/arch/i386/kernel/setup.c Thu Aug 21 01:32:04 2003
+++ edited/arch/i386/kernel/setup.c Thu Aug 21 12:09:13 2003
@@ -544,12 +544,6 @@
if (!acpi_force) acpi_disabled = 1;
}
-#ifdef CONFIG_X86_LOCAL_APIC
- /* disable IO-APIC */
- else if (!memcmp(from, "noapic", 6)) {
- skip_ioapic_setup = 1;
- }
-#endif /* CONFIG_X86_LOCAL_APIC */
#endif /* CONFIG_ACPI_BOOT */
/*
next reply other threads:[~2003-08-21 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-21 16:14 Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-21 17:09 [PATCH] 'noapic' already handled elsewhere Brown, Len
2003-08-21 21:11 ` Jeff Garzik
2003-08-21 21:33 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030821161436.GA15610@gtf.org \
--to=jgarzik@pobox.com \
--cc=andrew.grover@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.