Re: 2.6.0-test4 reiserfs oops

[Oleg Drokin <green@namesys.com>]

Hello!

On Tue, Aug 26, 2003 at 11:46:47AM +0000, Lorenzo Allegrucci wrote:
> > > I have got this oops running fsstress and fsx-linux
> > > on a 20Gb reiserfs partition.  Fully reproducible.
> > What are the options to fsx and fsstress?
> fsx-linux linux-2.5.0.tar.bz2 :)
> mkdir d
> fsstress -d d -n 1000000 -p 10
> The oops follows immediately.

works for me without any patches.
Do you have SMP? Some other system details?

> > Also I immediately see a place that can lead to an oops you quoted,
> > can you try to run with the patch attached and see if the oops go away?
> The oops goes away but fsx-linux hangs in "D" state.

Ah.
I see, we need to unlock the page. How about this patch instead?

Bye,
    Oleg
===== fs/reiserfs/inode.c 1.81 vs edited =====
--- 1.81/fs/reiserfs/inode.c	Tue Aug 19 09:42:17 2003
+++ edited/fs/reiserfs/inode.c	Tue Aug 26 14:27:32 2003
@@ -2048,8 +2048,8 @@
         last_offset = inode->i_size & (PAGE_CACHE_SIZE - 1) ;
 	/* no file contents in this page */
 	if (page->index >= end_index + 1 || !last_offset) {
-	    error = 0 ;
-	    goto done ;
+    	    unlock_page(page);
+	    return 0;
 	}
 	kaddr = kmap_atomic(page, KM_USER0);
 	memset(kaddr + last_offset, 0, PAGE_CACHE_SIZE-last_offset) ;