From: Christoph Hellwig <hch@lst.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] use mod_timer in scsi_add_timer
Date: Sun, 31 Aug 2003 14:53:57 +0200 [thread overview]
Message-ID: <20030831125356.GA20378@lst.de> (raw)
In-Reply-To: <1062334317.31351.30.camel@dhcp23.swansea.linux.org.uk>
On Sun, Aug 31, 2003 at 01:51:58PM +0100, Alan Cox wrote:
> On Sul, 2003-08-31 at 12:28, Christoph Hellwig wrote:
> > -
> > scmd->eh_timeout.data = (unsigned long)scmd;
> > - scmd->eh_timeout.expires = jiffies + timeout;
> > scmd->eh_timeout.function = (void (*)(unsigned long)) complete;
>
> And your change is racy too. You might now call the timer function with
> the data from the old timeout and the function of the new...
The data always is scmd.
next prev parent reply other threads:[~2003-08-31 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-31 11:28 [PATCH] use mod_timer in scsi_add_timer Christoph Hellwig
2003-08-31 12:51 ` Alan Cox
2003-08-31 12:53 ` Christoph Hellwig [this message]
2003-08-31 13:24 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030831125356.GA20378@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.