From: Dan Aloni <da-x@gmx.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: [BK PATCH 2.6] repost, fix sysctl breakage during network device renaming, for ipv4
Date: Mon, 1 Sep 2003 21:55:32 +0300 [thread overview]
Message-ID: <20030901185532.GA28941@callisto.yi.org> (raw)
In-Reply-To: <20030901113143.1ba34464.davem@redhat.com>
On Mon, Sep 01, 2003 at 11:31:43AM -0700, David S. Miller wrote:
> On Mon, 1 Sep 2003 19:55:59 +0300
> Dan Aloni <da-x@gmx.net> wrote:
>
> > The private copy of strdup() is something that I'd also wouldn't
> > want, but I don't have much choice. Please read a recent
> > thread in lkml regarding strdup() consolidation.
>
> Ugh, I'm afraid to look... I guess the controversy is
> over the allocation function, what GFP_* flags it should
> use etc.?
Yes, this is the one reason against consolidation, though
I don't know why anyone would want to call strdup() from a
context other than GPF_KERNEL. Copying strings around in the
kernel is done as a result of userspace interaction.
> For now just call the thing in your patch netdev_name_dup() or
> something like that. I can't handle having something named
> "strdup()" in there :-)
Sure, I'll do it and resend.
--
Dan Aloni
da-x@gmx.net
next prev parent reply other threads:[~2003-09-01 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 16:46 [BK PATCH 2.6] repost, fix sysctl breakage during network device renaming, for ipv4 Dan Aloni
2003-09-01 16:41 ` David S. Miller
2003-09-01 16:55 ` Dan Aloni
2003-09-01 18:31 ` David S. Miller
2003-09-01 18:55 ` Dan Aloni [this message]
2003-10-17 21:32 ` Dan Aloni
2003-10-18 7:01 ` David S. Miller
2003-10-18 11:20 ` Dan Aloni
2003-10-21 5:57 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030901185532.GA28941@callisto.yi.org \
--to=da-x@gmx.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.