From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: bunk@fs.tum.de, akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] Re: 2.6.0-test4-mm5
Date: Wed, 3 Sep 2003 20:21:20 -0700 [thread overview]
Message-ID: <20030903202120.3671596a.davem@redhat.com> (raw)
In-Reply-To: <3F5617A9.4040603@pobox.com>
On Wed, 03 Sep 2003 12:32:41 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> David, would you look over this patch and apply/modify?
Applied, thanks Jeff.
> I would prefer to use the generic ethtool_op_get_link, because (a)
> sungem is already using netif_carrier_xxx, and (b) if ->get_link ever
> returns an incorrect value, that signals a netif_carrier_xxx bug exists.
Agreed.
> As a tangent, gem_pcs_interrupt appears to call netif_carrier_xxx but
> not set gem->lstate. David/Ben, is that a bug?
Doesn't really matter, I don't think the rest of the PCS code even
cares about the setting of gem-lstate.
next prev parent reply other threads:[~2003-09-04 3:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-03 6:18 2.6.0-test4-mm5 Andrew Morton
2003-09-03 6:18 ` 2.6.0-test4-mm5 Andrew Morton
2003-09-03 7:17 ` 2.6.0-test4-mm5 Christian Axelsson
2003-09-03 7:17 ` 2.6.0-test4-mm5 Christian Axelsson
2003-09-03 18:29 ` 2.6.0-test4-mm5 William Lee Irwin III
2003-09-03 18:29 ` 2.6.0-test4-mm5 William Lee Irwin III
2003-09-03 16:12 ` 2.6.0-test4-mm5 Adrian Bunk
2003-09-03 16:32 ` [PATCH] 2.6.0-test4-mm5 Jeff Garzik
2003-09-03 16:46 ` Benjamin Herrenschmidt
2003-09-03 23:31 ` Jeff Garzik
2003-09-04 7:29 ` Benjamin Herrenschmidt
2003-09-04 3:21 ` David S. Miller [this message]
2003-09-03 17:02 ` 2.6.0-test4-mm5: SCSI imm driver doesn't compile Adrian Bunk
2003-09-04 13:30 ` Arnaldo Carvalho de Melo
2003-09-04 13:52 ` Jan-Benedict Glaw
2003-09-04 14:30 ` Christoph Hellwig
2003-09-04 14:54 ` Jan-Benedict Glaw
2003-09-04 17:50 ` [new patch] " Adrian Bunk
2003-09-04 22:19 ` 2.6-test4: mpspec.h:6:25: mach_mpspec.h: Missing file John Donnelly
2003-09-05 14:02 ` Matthew Wilcox
2003-09-05 17:12 ` 2.6-test4: " jd
2003-09-03 23:08 ` 2.6.0-test4-mm5 Diego Calleja García
2003-09-04 1:32 ` 2.6.0-test4-mm5 Nick Piggin
2003-09-04 18:23 ` 2.6.0-test4-mm5 Diego Calleja García
2003-09-04 19:08 ` 2.6.0-test4-mm5 Mike Fedyk
2003-09-05 15:36 ` 2.6.0-test4-mm5 Martin Schlemmer
2003-09-05 16:17 ` 2.6.0-test4-mm5 Nick Piggin
2003-09-05 18:05 ` 2.6.0-test4-mm5 Diego Calleja García
2003-09-04 2:04 ` 2.6.0-test4-mm5 Mike Fedyk
2003-09-04 3:10 ` 2.6.0-test4-mm5 Nick Piggin
2003-09-04 1:30 ` 2.6.0-test4-mm5 Bill Huey
2003-09-04 3:12 ` 2.6.0-test4-mm5 Chris Wright
2003-09-04 14:29 ` 2.6.0-test4-mm5 Bruno T. Moura
2003-09-04 14:44 ` 2.6.0-test4-mm5 Bruno T. Moura
2003-09-04 20:29 ` 2.6.0-test4-mm5 Alan Cox
2003-09-07 10:08 ` 2.6.0-test4-mm5 and below: Wine and XMMS problems Adrian Bunk
2003-09-07 10:08 ` Adrian Bunk
2003-09-07 10:39 ` Nick Piggin
2003-09-07 10:39 ` Nick Piggin
2003-09-08 23:08 ` Adrian Bunk
2003-09-08 23:08 ` Adrian Bunk
2003-09-10 22:03 ` Adrian Bunk
2003-09-10 22:03 ` Adrian Bunk
2003-09-07 12:18 ` Con Kolivas
2003-09-07 19:04 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030903202120.3671596a.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.