From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265788AbTIEUUe (ORCPT ); Fri, 5 Sep 2003 16:20:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265855AbTIEUUe (ORCPT ); Fri, 5 Sep 2003 16:20:34 -0400 Received: from dclient217-162-108-200.hispeed.ch ([217.162.108.200]:51972 "EHLO ritz.dnsalias.org") by vger.kernel.org with ESMTP id S265788AbTIEUS2 (ORCPT ); Fri, 5 Sep 2003 16:18:28 -0400 From: Daniel Ritz Reply-To: daniel.ritz@gmx.ch To: Russell King Subject: Re: Problems with PCMCIA (Texas Instruments PCI1450) Date: Fri, 5 Sep 2003 22:17:14 +0200 User-Agent: KMail/1.5.2 Cc: Sven Dowideit , linux-kernel , Tom Marshall References: <200308270056.33190.daniel.ritz@gmx.ch> <200309052140.27906.daniel.ritz@gmx.ch> <20030905205429.D14076@flint.arm.linux.org.uk> In-Reply-To: <20030905205429.D14076@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200309052217.14023.daniel.ritz@gmx.ch> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri September 5 2003 21:54, Russell King wrote: > On Fri, Sep 05, 2003 at 09:40:27PM +0200, Daniel Ritz wrote: > > On Fri September 5 2003 20:38, Russell King wrote: > > > On Fri, Sep 05, 2003 at 08:19:28PM +0200, Daniel Ritz wrote: > > > > ok, now i can reproduce the problem on my ti1410 too. on boot detection > > > > works fine with an UP kernel and fails with an SMP kernel. thanx for the > > > > hint. > > > > > > > > i go to look at the csets a bit and try to find out more.... > > > > (i think i know which change...) > > > > > > Care to provide a hint? > > > > yes. just tested. patch below makes on boot detection with a SMP kernel > > working again (for me). which is nice, but i don't see why it is better > > that way... > > Ok, now I need to hear from Sven (and others) to see if this patch fixes > their problems. Also, are these other people running a SMP kernel as > well? > > Meanwhile, I'm wondering if we have a timing problem here. Can you check > whether adding a mdelay(1) just after the BUG_ON in the original code > fixes the problem? no effect. i tried that before with loooong sleeps (1 second) w/o any effect... > > > ===== cs.c 1.56 vs edited ===== > > --- 1.56/drivers/pcmcia/cs.c Sun Aug 3 14:48:43 2003 > > +++ edited/cs.c Fri Sep 5 21:42:09 2003 > > @@ -316,7 +316,6 @@ > > > > wait_for_completion(&socket->thread_done); > > BUG_ON(!socket->thread); > > - pcmcia_parse_events(socket, SS_DETECT); > > > > return 0; > > } > > @@ -1524,6 +1523,9 @@ > > if (client == NULL) > > return CS_OUT_OF_RESOURCE; > > > > + if (++s->real_clients == 1) > > + pcmcia_parse_events(s, SS_DETECT); > > + > > *handle = client; > > client->state &= ~CLIENT_UNBOUND; > > client->Socket = s; > > > > -- > Russell King (rmk@arm.linux.org.uk) http://www.arm.linux.org.uk/personal/ > Linux kernel maintainer of: > 2.6 ARM Linux - http://www.arm.linux.org.uk/ > 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ > 2.6 Serial core > >