From: Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org>
To: Andrew de Quincey <adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-acpi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] 2.6.0-test4 Fix mpparse properly
Date: Mon, 8 Sep 2003 04:25:48 +0200 [thread overview]
Message-ID: <20030908042548.3bbfcf7d.ak@suse.de> (raw)
In-Reply-To: <200309072130.40200.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
On Sun, 7 Sep 2003 21:30:40 +0100
Andrew de Quincey <adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org> wrote:
>
> --- linux-2.6.0-test4.null_crs/arch/i386/kernel/mpparse.c 2003-09-06 00:23:10.000000000 +0100
> +++ linux-2.6.0-test4.es7000fix/arch/i386/kernel/mpparse.c 2003-09-07 15:53:41.369717552 +0100
> @@ -1129,8 +1129,10 @@
> continue;
> ioapic_pin = irq - mp_ioapic_routing[ioapic].irq_start;
>
> +#ifdef CONFIG_X86_ES7000
> if (!ioapic && (irq < 16))
> irq += 16;
> +#endif
That won't work for an "generic" subarch kernel that supports the ES7000 and other boxes too.
You should test es7000_plat instead (that's currently a static in the es7000 code, needs to be unstatic'ed).
At least one 2.4 distribution kernel does it this way.
-Andi
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
next prev parent reply other threads:[~2003-09-08 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-07 20:30 [PATCH] 2.6.0-test4 Fix mpparse properly Andrew de Quincey
[not found] ` <200309072130.40200.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
2003-09-08 2:25 ` Andi Kleen [this message]
[not found] ` <20030908042548.3bbfcf7d.ak-l3A5Bk7waGM@public.gmane.org>
2003-09-08 10:02 ` Andrew de Quincey
[not found] ` <20030908144934.GE5826@wotan.suse.de>
[not found] ` <20030908144934.GE5826-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2003-09-08 15:07 ` Andrew de Quincey
[not found] ` <200309081607.59047.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
2003-09-08 15:29 ` Andi Kleen
[not found] ` <20030908152926.GH5826-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2003-09-09 13:08 ` [PATCH] 2.6.0-test4 Fix mpparse properly mark 2 Andrew de Quincey
[not found] ` <200309091408.00619.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
2003-09-09 13:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908042548.3bbfcf7d.ak@suse.de \
--to=ak-l3a5bk7wagm@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org \
--cc=linux-acpi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.