From: viro@parcelfarce.linux.theplanet.co.uk
To: Stephen Hemminger <shemminger@osdl.org>
Cc: jffs-dev@axis.com, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] fix type mismatch in jffs.
Date: Wed, 10 Sep 2003 03:40:10 +0100 [thread overview]
Message-ID: <20030910024010.GN454@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030909144420.120d4add.shemminger@osdl.org>
On Tue, Sep 09, 2003 at 02:44:20PM -0700, Stephen Hemminger wrote:
> On 2.6.0-test5 jffs generates a warning about type mismatch because it casting a short
> to a pointer. Look like an obvious typo.
Which it is. Thanks for spotting. Linux, please apply.
> Builds clean, not tested on real hardware.
>
> diff -Nru a/fs/jffs/inode-v23.c b/fs/jffs/inode-v23.c
> --- a/fs/jffs/inode-v23.c Tue Sep 9 14:41:53 2003
> +++ b/fs/jffs/inode-v23.c Tue Sep 9 14:41:53 2003
> @@ -1734,7 +1734,7 @@
> the device should be read from the flash memory and then
> added to the inode's i_rdev member. */
> u16 val;
> - jffs_read_data(f, (char *)val, 0, 2);
> + jffs_read_data(f, (char *)&val, 0, 2);
> init_special_inode(inode, inode->i_mode,
> old_decode_dev(val));
> }
next prev parent reply other threads:[~2003-09-10 2:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 21:44 [PATCH] fix type mismatch in jffs Stephen Hemminger
2003-09-10 2:40 ` viro [this message]
2003-09-10 17:14 ` Geert Uytterhoeven
2003-09-10 18:18 ` viro
2003-09-10 18:54 ` Linus Torvalds
2003-09-10 19:03 ` viro
2003-09-10 19:16 ` Russell King
2003-09-11 16:50 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030910024010.GN454@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.