All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Matt Domsch <Matt_Domsch@Dell.com>
Cc: rmk@arm.linux.org.uk, Dave Jones <davej@redhat.com>,
	Anatoly Pugachev <mator@gsib.ru>,
	linux-kernel@vger.kernel.org
Subject: Re: Buggy PCI drivers - do not mark pci_device_id as discardable data
Date: Tue, 9 Sep 2003 21:24:28 -0700	[thread overview]
Message-ID: <20030910042428.GA10134@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0309091752320.17200-100000@localhost.localdomain>

On Tue, Sep 09, 2003 at 06:12:48PM -0500, Matt Domsch wrote:
> > > agp_serverworks_probe() is marked __init.  Thus the static lookup
> > Ah, Russell just got a patch for this into the tree today.
> 
> Thanks Russell.  However, I believe your patch only fixes the
> pci_device_id tables marked __initdata, not the probe functions (or
> anything they call) being marked __init, which is what Anatoly tripped up.  
> 
> At least these have probe functions marked __init in -test5.

These either need to be marked __devinit and make "new_id" dependant on
CONFIG_HOTPLUG, or we need to remove the __init marker on these
functions.

Any throughts about which?

thanks,

greg k-h

  reply	other threads:[~2003-09-10  4:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030905000452.GF12613@kroah.com>
2003-09-09 22:22 ` agpgart support for intel SHG2 motherboard, serverworks chipset Matt Domsch
2003-09-10  3:35   ` Greg KH
2003-09-09 23:12     ` Buggy PCI drivers - do not mark pci_device_id as discardable data Matt Domsch
2003-09-10  4:24       ` Greg KH [this message]
2003-09-10  9:31         ` Matt Domsch
2003-09-10 17:17           ` Matt Domsch
2003-09-11 21:20             ` Greg KH
2003-09-09 19:48 Russell King
2003-09-09 20:02 ` Zwane Mwaikambo
2003-09-09 20:59   ` Russell King
2003-09-09 21:04   ` Russell King
2003-09-09 21:22     ` Alan Cox
2003-09-09 21:28       ` Zwane Mwaikambo
2003-09-09 21:33       ` Russell King
2003-09-09 20:14 ` Dave Jones
2003-09-09 20:57   ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030910042428.GA10134@kroah.com \
    --to=greg@kroah.com \
    --cc=Matt_Domsch@Dell.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mator@gsib.ru \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.