From: Matt Mackall <mpm@selenic.com>
To: Mitchell Blank Jr <mitch@sfgoth.com>
Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu
Subject: Re: [PATCH 2/3] netpoll: netconsole
Date: Fri, 12 Sep 2003 00:57:25 -0500 [thread overview]
Message-ID: <20030912055725.GV4489@waste.org> (raw)
In-Reply-To: <20030912053335.GJ41254@gaz.sfgoth.com>
On Thu, Sep 11, 2003 at 10:33:35PM -0700, Mitchell Blank Jr wrote:
> Mitchell Blank Jr wrote:
> > The netconsole problem is only if the net driver calls printk() with
> > its spinlock held (but when not called from netconsole). Then printk()
> > won't know that it's unsafe to re-enter the network driver.
>
> BTW, this isn't neccesarily a netconsole-only thing. For instance, has
> anyone ever audited all of the serial and lp drivers to make sure that
> nothing they call can call printk() while holding a lock? This sounds
> fairly serious - we could have any number of simple error cases that would
> cause a deadlock with the right "console=" setting.
I have a spinlock debugging patch somewhere that builds a list of
locks held by each process. It could easily be extended to do
detecting of recursive locking.
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-09-12 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030910074256.GD4489@waste.org.suse.lists.linux.kernel>
2003-09-10 8:11 ` [PATCH 2/3] netpoll: netconsole Andi Kleen
2003-09-10 8:24 ` Matt Mackall
2003-09-10 8:29 ` Andi Kleen
2003-09-10 9:01 ` Matt Mackall
2003-09-10 16:00 ` Mitchell Blank Jr
2003-09-12 5:33 ` Mitchell Blank Jr
2003-09-12 5:57 ` Matt Mackall [this message]
2003-09-12 19:40 ` Andrew Morton
2003-09-10 7:42 Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030912055725.GV4489@waste.org \
--to=mpm@selenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
--cc=mitch@sfgoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.