From: "David S. Miller" <davem@redhat.com>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: laforge@netfilter.org, acme@conectiva.com.br,
netfilter-devel@lists.netfilter.org, netdev@oss.sgi.com
Subject: Re: ipt_physdev.c alignment problems on parisc64
Date: Sat, 13 Sep 2003 19:25:22 -0700 [thread overview]
Message-ID: <20030913192522.58705cb0.davem@redhat.com> (raw)
In-Reply-To: <200309132159.37834.bdschuym@pandora.be>
On Sat, 13 Sep 2003 21:59:37 +0200
Bart De Schuymer <bdschuym@pandora.be> wrote:
> It just uses unsigned int instead of unsigned long, so there should
> be no problem with the evil Sparc64.
Sparc64 doesn't have the problems, it just fixes up the unaligned
accesses there so it'll just be super-slow (some "optimization" :).
The problem is on parisc64 which is very strict about accessing
structure members which are not aligned to the accessor type you use
to dereference and gives you a link/compile error when you violate
this.
> Perhaps the ip_tables.c code from which I copied the original code
> should be altered too.
Yes.
> It's a real optimization btw, the .o file is 32 bytes
> larger when doing the bit operations on a char with i<IFNAMSIZ.
> All hail Rusty :)
I understand, but instead create an arch routine to optimize this
instead of using non-portable constructs. memcmp_masked() or
something like that.
next prev parent reply other threads:[~2003-09-14 2:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-02 14:30 ipt_physdev.c alignment problems on parisc64 Arnaldo Carvalho de Melo
2003-09-02 19:16 ` Bart De Schuymer
2003-09-02 20:03 ` Arnaldo Carvalho de Melo
2003-09-04 3:04 ` David S. Miller
2003-09-05 15:31 ` Harald Welte
2003-09-09 2:14 ` David S. Miller
2003-09-13 19:59 ` Bart De Schuymer
2003-09-14 2:25 ` David S. Miller [this message]
2003-09-15 22:59 ` David S. Miller
2003-09-16 6:05 ` Bart De Schuymer
2003-09-16 6:02 ` David S. Miller
2003-09-16 9:18 ` Henrik Nordstrom
2003-09-16 14:09 ` Harald Welte
2003-09-17 1:16 ` David S. Miller
2003-09-17 21:17 ` Bart De Schuymer
2003-09-19 2:48 ` David S. Miller
2003-09-20 11:32 ` Bart De Schuymer
2003-09-20 16:05 ` Arnaldo Carvalho de Melo
2003-09-22 0:53 ` David S. Miller
2003-09-16 14:06 ` Harald Welte
2003-09-16 15:15 ` Tom Marshall
2003-09-16 15:57 ` Bart De Schuymer
2003-09-17 1:23 ` David S. Miller
2003-09-17 6:42 ` Bart De Schuymer
2003-09-17 6:56 ` David S. Miller
2003-09-12 1:40 ` jamal
2003-09-12 8:56 ` Harald Welte
2003-09-12 10:56 ` Oskar Andreasson
2003-09-12 12:56 ` jamal
2003-09-12 13:55 ` Oskar Andreasson
2003-09-12 12:54 ` jamal
2003-09-20 5:50 ` Harald Welte
2003-09-21 13:57 ` ppp ifindex WAS(Re: " jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030913192522.58705cb0.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=bdschuym@pandora.be \
--cc=laforge@netfilter.org \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.