From: Anton Blanchard <anton@samba.org>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] serialize bus scanning
Date: Mon, 15 Sep 2003 17:13:05 +1000 [thread overview]
Message-ID: <20030915071305.GA820@krispykreme> (raw)
In-Reply-To: <20030911133419.A10316@beaverton.ibm.com>
Hi Pat,
> The patch looks fine to me, I hope James will apply it.
Good to see someone else does parallel scan :)
> I think we might still have to allow only a scan or delete (per host), and
> not both in parallel - it looks like we could have some races otherwise,
> I'm not sure though (mainly where the driver model points to the parent
> device). Maybe a get of the host device during scanning is enough.
Speaking of races... Ive been tripping one when parallel probing.
I hit a poisoned list pointer in scsi_run_host_queues, which is being
called out of the error handler thread. (Ive got a few scsi buses in this
machine full of bad disks)
I havent had a chance to look into it but Im guessing we are racing with
someone calling scsi_free_sdev. Im not sure how we should be protecting
->siblings but it looks like we have to do something.
Anton
next prev parent reply other threads:[~2003-09-15 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-25 12:24 [PATCH] serialize bus scanning Christoph Hellwig
2003-08-27 20:29 ` Anton Blanchard
2003-08-27 20:35 ` Christoph Hellwig
2003-09-10 7:57 ` Anton Blanchard
2003-09-11 20:34 ` Patrick Mansfield
2003-09-15 7:13 ` Anton Blanchard [this message]
2003-09-15 9:10 ` Christoph Hellwig
2003-08-27 22:32 ` Mike Anderson
2003-08-27 22:59 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030915071305.GA820@krispykreme \
--to=anton@samba.org \
--cc=James.Bottomley@SteelEye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.