From: Muli Ben-Yehuda <mulix@mulix.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move some more intilization out of drivers/char/mem.c
Date: Sun, 21 Sep 2003 10:54:30 +0300 [thread overview]
Message-ID: <20030921075430.GA4938@actcom.co.il> (raw)
In-Reply-To: <20030920234853.7e09f663.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]
On Sat, Sep 20, 2003 at 11:48:53PM -0700, Andrew Morton wrote:
> Christoph Hellwig <hch@lst.de> wrote:
> >
> > > Please compile-test things...
> >
> > Well, I compiled this here. I see, looks like I lost half of the patch
> > when sending it to you. Sorryh for that, here's the full patch:
>
> It still generates warnings. I suggest you build kernels with a script
> which saves up stderr and spits it all out at the end. That way, these
> things are noticed.
This might be a good time to recommend -Werror. Last time it came up
(http://marc.theaimsgroup.com/?l=linux-kernel&m=102654562025374&w=2),
Alan was dead set against it, and Linus did not apply it, but did
think it had some merit
(http://marc.theaimsgroup.com/?l=linux-kernel&m=102658611213914&w=2).
Compiling 2.6.0-t5-cvs with my .config and -Werror uncovered only two
warnings. Patches sent seperately.
diff --exclude-from /home/muli/p/dontdiff -Naur ../linux-2.5/Makefile 2.6.0-t5-Werror/Makefile
--- ../linux-2.5/Makefile Wed Sep 10 16:21:16 2003
+++ 2.6.0-t5-Werror/Makefile Sun Sep 21 09:59:29 2003
@@ -73,7 +73,7 @@
HOSTCC = gcc
HOSTCXX = g++
-HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
HOSTCXXFLAGS = -O2
@@ -223,8 +223,8 @@
NOSTDINC_FLAGS = -nostdinc -iwithprefix include
CPPFLAGS := -D__KERNEL__ -Iinclude
-CFLAGS := -Wall -Wstrict-prototypes -Wno-trigraphs -O2 \
- -fno-strict-aliasing -fno-common
+CFLAGS := -Wall -Werror -Wstrict-prototypes -Wno-trigraphs \
+ -O2 -fno-strict-aliasing -fno-common
AFLAGS := -D__ASSEMBLY__
export VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION KERNELRELEASE ARCH \
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-09-21 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-20 13:29 [PATCH] move some more intilization out of drivers/char/mem.c Christoph Hellwig
2003-09-20 23:06 ` Andrew Morton
2003-09-21 6:30 ` Christoph Hellwig
2003-09-21 6:48 ` Andrew Morton
2003-09-21 7:05 ` Christoph Hellwig
2003-09-21 17:03 ` Randy.Dunlap
2003-09-21 7:54 ` Muli Ben-Yehuda [this message]
2003-09-22 11:13 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030921075430.GA4938@actcom.co.il \
--to=mulix@mulix.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.