All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Vollmert <rvollmert-lists-hi6Y0CQ0nG0@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: bug report: multi-byte access in indexfields broken
Date: Sun, 21 Sep 2003 22:05:25 +0200	[thread overview]
Message-ID: <20030921200525.GB2968@krikkit> (raw)

Hello,

it appears the problems I mailed about earlier are due to a bug in the
ACPI code. Reading from multi-byte fields in a ByteAccess-IndexField
seems to be broken.

When I replace

IndexField (EIND, EDAT, ByteAcc, NoLock, Preserve)
{
    Offset (0x10), 
    IKFG,   8, 
    FRPN,   16, 
    RAMB,   32,
    AVOL,   8, 
...
}

Method (CRMB, 0, NotSerialized)
{
    Return (RAMB)
}

with

IndexField (EIND, EDAT, ByteAcc, NoLock, Preserve)
{
    Offset (0x10), 
    IKFG,   8, 
    FRPN,   16, 
    RAM0,   8,
    RAM1,   8,
    RAM2,   8,
    RAM3,   8,
    AVOL,   8, 
...
}

Method (CRMB, 0, NotSerialized)
{
    Store (RAM3, Local0)
    ShiftLeft (Local0, 0x8, Local0)
    Add (RAM2, Local0, Local0)
    ShiftLeft (Local0, 0x8, Local0)
    Add (RAM1, Local0, Local0)
    ShiftLeft (Local0, 0x8, Local0)
    Add (RAM0, Local0, Local0)
    Return (Local0)
}

the first version of CRMB computes 0x64646464, while the second
version computes the correct 0x0F750064. The least byte seems to just
be copied to the other positions.

Cheers
Robert


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

             reply	other threads:[~2003-09-21 20:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-21 20:05 Robert Vollmert [this message]
     [not found] ` <20030921200525.GB2968-duT3ICHXG/I@public.gmane.org>
2003-09-21 20:16   ` bug report: multi-byte access in indexfields broken Robert Vollmert
2003-09-22 14:02   ` Ducrot Bruno
2003-09-22 17:29   ` bug report: multi-byte access in indexfields broken [patch] Robert Vollmert
  -- strict thread matches above, loose matches on Subject: below --
2003-09-23  1:46 bug report: multi-byte access in indexfields broken Li, Shaohua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030921200525.GB2968@krikkit \
    --to=rvollmert-lists-hi6y0cq0ng0@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.