From: John Levon <levon@movementarian.org>
To: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] add -Wdeclaration-after-statement
Date: Mon, 22 Sep 2003 01:39:10 +0100 [thread overview]
Message-ID: <20030922003910.GA17030@compsoc.man.ac.uk> (raw)
Not that many people are going to be using GCC 3.4 currently, but it
might help a bit to prevent compilation bugs like that just witnessed
in procfs.
regards,
john
diff -Naurp -X dontdiff linux-cvs/arch/arm/Makefile linux-fixes/arch/arm/Makefile
--- linux-cvs/arch/arm/Makefile 2003-09-12 15:10:41.000000000 +0100
+++ linux-fixes/arch/arm/Makefile 2003-09-22 01:52:43.000000000 +0100
@@ -27,7 +27,6 @@ LD += -EB
AFLAGS += -mbig-endian
endif
-check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)
comma = ,
# This selects which instruction set is used.
diff -Naurp -X dontdiff linux-cvs/arch/i386/Makefile linux-fixes/arch/i386/Makefile
--- linux-cvs/arch/i386/Makefile 2003-08-14 13:21:12.000000000 +0100
+++ linux-fixes/arch/i386/Makefile 2003-09-22 01:48:44.000000000 +0100
@@ -21,8 +21,6 @@ LDFLAGS_vmlinux :=
CFLAGS += -pipe
-check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)
-
# prevent gcc from keeping the stack 16 byte aligned
CFLAGS += $(call check_gcc,-mpreferred-stack-boundary=2,)
diff -Naurp -X dontdiff linux-cvs/arch/mips/Makefile linux-fixes/arch/mips/Makefile
--- linux-cvs/arch/mips/Makefile 2003-08-04 19:40:30.000000000 +0100
+++ linux-fixes/arch/mips/Makefile 2003-09-22 01:53:23.000000000 +0100
@@ -58,7 +58,6 @@ MODFLAGS += -mlong-calls
cflags-$(CONFIG_KGDB) += -g
cflags-$(CONFIG_SB1XXX_CORELIS) += -mno-sched-prolog -fno-omit-frame-pointer
-check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)
check_warning = $(shell if $(CC) $(1) -c -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)
#
diff -Naurp -X dontdiff linux-cvs/arch/s390/Makefile linux-fixes/arch/s390/Makefile
--- linux-cvs/arch/s390/Makefile 2003-08-04 19:40:42.000000000 +0100
+++ linux-fixes/arch/s390/Makefile 2003-09-22 01:52:18.000000000 +0100
@@ -13,8 +13,6 @@
# Copyright (C) 1994 by Linus Torvalds
#
-check_gcc = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)
-
ifdef CONFIG_ARCH_S390_31
LDFLAGS := -m elf_s390
CFLAGS += -m31
diff -Naurp -X dontdiff linux-cvs/Makefile linux-fixes/Makefile
--- linux-cvs/Makefile 2003-09-12 15:10:36.000000000 +0100
+++ linux-fixes/Makefile 2003-09-22 01:55:31.000000000 +0100
@@ -183,7 +183,9 @@ ifneq ($(findstring s,$(MAKEFLAGS)),)
quiet=silent_
endif
-export quiet Q KBUILD_VERBOSE
+check_gcc = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
+
+export quiet Q KBUILD_VERBOSE check_gcc
# Paths to obj / src tree
@@ -378,6 +380,9 @@ ifdef CONFIG_DEBUG_INFO
CFLAGS += -g
endif
+# warn about C99 declaration after statement
+CFLAGS += $(call check_gcc,-Wdeclaration-after-statement,)
+
#
# INSTALL_PATH specifies where to place the updated kernel and system map
# images. Uncomment if you want to place them anywhere other than root.
reply other threads:[~2003-09-22 0:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030922003910.GA17030@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.