From: "David S. Miller" <davem@redhat.com>
To: David Brownell <david-b@pacbell.net>
Cc: hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: assertion failure at net/sched/sch_generic.c(530)
Date: Tue, 23 Sep 2003 17:02:16 -0700 [thread overview]
Message-ID: <20030923170216.32eaff53.davem@redhat.com> (raw)
In-Reply-To: <3F70E12A.1090204@pacbell.net>
On Tue, 23 Sep 2003 17:11:22 -0700
David Brownell <david-b@pacbell.net> wrote:
> KERNEL: assertion (dev->qdisc_list == NULL) failed at
> net/sched/sch_generic.c(530)
Crap, I think I know what made this start happening.
Jamal, your pfifo_fast statistics patch added this to
dev_activate() when we decide to add a default discipline:
write_lock(&qdisc_tree_lock);
qdisc->next = dev->qdisc_list;
dev->qdisc_list = qdisc;
write_unlock(&qdisc_tree_lock);
Something probably isn't clearing it later on when we
down the device.
Doesn't the ->reset() operation need to do this list
removal? If so, that's the problem, pfifo_fast_reset()
isn't doing the dev->qdisc_list removal. Actually it seems
like qdisc_destroy() takes care of it.
Or another possibility is that pfifo_fast is being added
twice to the list.
next prev parent reply other threads:[~2003-09-24 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 0:11 assertion failure at net/sched/sch_generic.c(530) David Brownell
2003-09-24 0:02 ` David S. Miller [this message]
2003-09-24 0:08 ` David S. Miller
2003-09-24 0:44 ` David Brownell
2003-09-24 0:42 ` David S. Miller
2003-09-24 15:10 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923170216.32eaff53.davem@redhat.com \
--to=davem@redhat.com \
--cc=david-b@pacbell.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.