From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] don't set underflow for REQ_BLOCK_PC Date: Wed, 24 Sep 2003 14:27:50 +0200 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20030924122750.GC15415@suse.de> References: <20030922125009.A3244@beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns.virtualhost.dk ([195.184.98.160]:51429 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S261284AbTIXM1y (ORCPT ); Wed, 24 Sep 2003 08:27:54 -0400 Content-Disposition: inline In-Reply-To: <20030922125009.A3244@beaverton.ibm.com> List-Id: linux-scsi@vger.kernel.org To: Patrick Mansfield Cc: James Bottomley , linux-scsi@vger.kernel.org On Mon, Sep 22 2003, Patrick Mansfield wrote: > I got underflow warnings and failures when sending an INQUIRY page 0x83 > via the SG_IO REQ_BLOCK_PC interface. > > The underflow field should only be set if we know for certain the size of > the data being transfered, so fix this by leaving it at zero for scsi > REQ_BLOCK_PC cases. > > diff -uprN -X /home/patman/dontdiff bl-25/drivers/scsi/sd.c bl-25-sd_underflow-fix/drivers/scsi/sd.c > --- bl-25/drivers/scsi/sd.c Mon Sep 8 14:50:56 2003 > +++ bl-25-sd_underflow-fix/drivers/scsi/sd.c Tue Sep 16 16:58:14 2003 > @@ -174,7 +174,6 @@ static int sd_init_command(struct scsi_c > timeout = rq->timeout; > > SCpnt->transfersize = rq->data_len; > - SCpnt->underflow = rq->data_len; > goto queue; > } > > diff -uprN -X /home/patman/dontdiff bl-25/drivers/scsi/sr.c bl-25-sd_underflow-fix/drivers/scsi/sr.c > --- bl-25/drivers/scsi/sr.c Mon Sep 8 14:50:56 2003 > +++ bl-25-sd_underflow-fix/drivers/scsi/sr.c Tue Sep 16 16:58:27 2003 > @@ -301,7 +301,6 @@ static int sr_init_command(struct scsi_c > timeout = rq->timeout; > > SCpnt->transfersize = rq->data_len; > - SCpnt->underflow = rq->data_len; > goto queue; > } Agree, looks fine. -- Jens Axboe