From: "David S. Miller" <davem@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] 2.6.0-bk6 net/core/dev.c
Date: Thu, 25 Sep 2003 03:01:09 -0700 [thread overview]
Message-ID: <20030925030109.09bbedca.davem@redhat.com> (raw)
In-Reply-To: <1064423867.15283.11.camel@localhost.localdomain>
On Wed, 24 Sep 2003 10:17:47 -0700
Joe Perches <joe@perches.com> wrote:
> On Wed, 2003-09-24 at 10:13, Linus Torvalds wrote:
> > Looks sane, but wouldn't it be cleaner to put this ugly special case logic
> > with casts etc in an inline function and make the code a bit more readable
> > at the same time?
>
> I've got those.
>
> I've done the ((void*)1) conversions to PKT_SHARED_SKBs
> and found this missing. I'll submit those separately.
Send me what you have and I'll review and apply it.
I haven't accomplished anything today because I've been sick,
but tomorrow I should be back to full speed once more.
next prev parent reply other threads:[~2003-09-25 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 15:11 [PATCH] 2.6.0-bk6 net/core/dev.c Joe Perches
2003-09-24 17:13 ` Linus Torvalds
2003-09-24 17:17 ` Joe Perches
2003-09-24 22:33 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h Joe Perches
2003-09-24 22:36 ` Linus Torvalds
2003-09-25 10:49 ` David S. Miller
2003-09-25 10:01 ` David S. Miller [this message]
2003-09-24 22:33 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [2/3] drivers/net/* Joe Perches
2003-09-24 22:33 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [3/3] net/* Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030925030109.09bbedca.davem@redhat.com \
--to=davem@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.