From: Jens Axboe <axboe@suse.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] REQ_BLOCK_PC only returns SCSI status byte
Date: Thu, 25 Sep 2003 21:51:51 +0200 [thread overview]
Message-ID: <20030925195151.GL15415@suse.de> (raw)
In-Reply-To: <20030925111848.A26884@beaverton.ibm.com>
On Thu, Sep 25 2003, Patrick Mansfield wrote:
> Jens/James -
>
> Can you please apply or comment?
>
> Only the low byte of the linux scsi result is being returned for
> REQ_BLOCK_PC usage. This means driver errors such as DID_ERROR are not
> returned to user space.
>
> The ide-cd.c code looks like it should be OK with this patch, but I did
> not test it. I tested using SG_IO to an sd, for the case of DID_ERROR
> coming back from the qlogic adapter (with underflow set, it was returning
> DID_ERROR).
Patch looks fine to me, applied.
--
Jens Axboe
prev parent reply other threads:[~2003-09-25 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-25 18:18 [PATCH] REQ_BLOCK_PC only returns SCSI status byte Patrick Mansfield
2003-09-25 19:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030925195151.GL15415@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.