All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Len Brown <len.brown@intel.com>
Cc: marcelo@parcelfarce.linux.theplanet.co.uk,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: HT not working by default since 2.4.22
Date: Thu, 25 Sep 2003 23:49:51 -0400	[thread overview]
Message-ID: <20030926034951.GA12338@gtf.org> (raw)
In-Reply-To: <1064547463.2981.833.camel@dhcppc4>

On Thu, Sep 25, 2003 at 11:37:43PM -0400, Len Brown wrote:
> > How about the more simple CONFIG_HYPERTHREAD or CONFIG_HT?
> > 
> > If enabled and CONFIG_SMP is set, then we will attempt to discover HT 
> > via ACPI tables, regardless of CONFIG_ACPI value.
> 
> Yes, except I think we should keep the name CONFIG_ACPI_HT_ONLY since it
> says exactly what it does.
> 
> Hopefully I can make it looke clear in the menus --
> I think on the config menus for CONFIG_ACPI_HT_ONLY and CONFIG_ACPI
> should be mutually exclusive.

Now that I've thought of it (aren't I humble), I rather like CONFIG_HT.
It's simple and it's effects should be obvious to both developer and
user:

	CONFIG_HT, CONFIG_ACPI == ACPI
	!CONFIG_HT, CONFIG_ACPI == ACPI
	CONFIG_HT, !CONFIG_ACPI == HT-only ACPI
	!CONFIG_HT, !CONFIG_ACPI == no ACPI

Following the "autoconf model", what we really want to be testing with
CONFIG_xxx is _features_, where possible. "hyperthreading: yes/no" is
IMO more clear than "do I want ht-only ACPI or full ACPI", while at the
same time being more fine-grained and future-proof.


> > Or... (I know multiple people will shoot me for saying this) we could 
> > resurrect acpitable.[ch], and build that when CONFIG_ACPI is disabled.
> 
> The question about configs is independent of the acpitable.[ch] vs
> table.c implementation.  No, we should not return to maintaining two
> copies of the acpi table code.

Point; agreed.

	Jeff



  reply	other threads:[~2003-09-26  3:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-24 21:56 HT not working by default since 2.4.22 Brown, Len
2003-09-24 23:12 ` Tomas Szepe
2003-09-25 13:33 ` marcelo
2003-09-26  0:04   ` Jeff Garzik
2003-09-26  3:37     ` Len Brown
2003-09-26  3:49       ` Jeff Garzik [this message]
2003-09-27 15:26         ` Herbert Poetzl
     [not found] <BF1FE1855350A0479097B3A0D2A80EE0CC870C@hdsmsx402.hd.intel.com>
2003-09-28 10:43 ` Tomas Szepe
2003-09-28 10:46   ` Tomas Szepe
2003-09-29  1:41     ` Len Brown
2003-09-29  5:29       ` Tomas Szepe
  -- strict thread matches above, loose matches on Subject: below --
2003-09-26  4:54 Brown, Len
2003-09-26  7:44 ` Jan Evert van Grootheest
2003-09-26 17:38   ` Len Brown
     [not found]   ` <3F73EE77.3000906-R6hnfgSw+1uEVqv0pETR8A@public.gmane.org>
2003-09-30  5:27     ` Len Brown
2003-09-30  5:27       ` Len Brown
2003-09-26  1:13 Nakajima, Jun
2003-09-22 17:28 Brown, Len
2003-09-22 17:55 ` Jeff Garzik
2003-09-22 14:41 Nakajima, Jun
2003-09-22  9:00 Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030926034951.GA12338@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jun.nakajima@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com.br \
    --cc=marcelo@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.