From: David Gibson <hermes@gibson.dropbear.id.au>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: netdev@oss.sgi.com, jgarzik@pobox.com
Subject: Re: [PATRCH] janitor: hermes: delete verify_area call
Date: Mon, 29 Sep 2003 15:29:25 +1000 [thread overview]
Message-ID: <20030929052925.GA5037@zax> (raw)
In-Reply-To: <20030925215902.57f53822.rddunlap@osdl.org>
On Thu, Sep 25, 2003 at 09:59:02PM -0700, Randy.Dunlap wrote:
>
> Hi,
> Please apply to 2.6.0-test5-current.
>
> Thanks,
Sorry, can you clarify why this verify_area() is not needed?
From: Domen Puncer <domen@coderock.org>
IMO, that verify_area wasn't needed.
linux-260-t5bk12-kj-rddunlap/drivers/net/wireless/orinoco.c | 4
----
1 files changed, 4 deletions(-)
diff -puN drivers/net/wireless/orinoco.c~net_wireless_orinoco_verify
+drivers/net/wireless/orinoco.c
---
+linux-260-t5bk12-kj/drivers/net/wireless/orinoco.c~net_wireless_orinoco_verify
+2003-09-25 16:03:17.000000000 -0700
+++ linux-260-t5bk12-kj-rddunlap/drivers/net/wireless/orinoco.c
2003-09-25
+16:03:17.000000000 -0700
@@ -3833,10 +3833,6 @@ orinoco_ioctl(struct net_device *dev, st
{ SIOCIWLASTPRIV, 0, 0, "dump_recs" },
};
- err = verify_area(VERIFY_WRITE,
wrq->u.data.pointer,
+sizeof(privtab));
- if (err)
- break;
-
wrq->u.data.length = sizeof(privtab) /
+sizeof(privtab[0]);
if (copy_to_user(wrq->u.data.pointer, privtab,
+sizeof(privtab)))
err = -EFAULT;
_
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2003-09-29 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-26 4:59 [PATRCH] janitor: hermes: delete verify_area call Randy.Dunlap
2003-09-29 5:29 ` David Gibson [this message]
2003-09-29 20:06 ` Randy.Dunlap
2003-09-30 4:51 ` David Gibson
2003-09-30 5:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030929052925.GA5037@zax \
--to=hermes@gibson.dropbear.id.au \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.