From: Dave Jones <davej@redhat.com>
To: Sander van Malssen <svm@kozmix.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix leak in btaudio
Date: Wed, 1 Oct 2003 19:35:40 +0100 [thread overview]
Message-ID: <20031001183540.GE25612@redhat.com> (raw)
In-Reply-To: <20031001183145.GA5380@kozmix.org>
On Wed, Oct 01, 2003 at 08:31:45PM +0200, Sander van Malssen wrote:
> On Monday, 29 September 2003 at 18:04:34 +0100, davej@redhat.com wrote:
>
> > + pci_free_consistent(bta->pci, bta->buf_size, bta->buf_cpu, bta->dma);
>
>
> Surely bta->dma must be bta->buf_dma, like so:
>
>
> --- linux-2.6/sound/oss/btaudio.c.~1~ 2003-09-30 14:11:13.000000000 +0200
> +++ linux-2.6/sound/oss/btaudio.c 2003-10-01 20:28:47.000000000 +0200
> @@ -178,7 +178,7 @@
> bta->risc_cpu = pci_alloc_consistent
> (bta->pci, bta->risc_size, &bta->risc_dma);
> if (NULL == bta->risc_cpu) {
> - pci_free_consistent(bta->pci, bta->buf_size, bta->buf_cpu, bta->dma);
> + pci_free_consistent(bta->pci, bta->buf_size, bta->buf_cpu, bta->buf_dma);
> bta->buf_cpu = NULL;
> return -ENOMEM;
> }
Good eyes. Yes, looks correct to me.
Dave
--
Dave Jones http://www.codemonkey.org.uk
prev parent reply other threads:[~2003-10-01 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 17:04 [PATCH] fix leak in btaudio davej
2003-10-01 18:31 ` Sander van Malssen
2003-10-01 18:35 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001183540.GE25612@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=svm@kozmix.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.