From: Muli Ben-Yehuda <mulix@mulix.org>
To: J?rn Engel <joern@wohnheim.fh-wedel.de>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] CONFIG_* In Comments Considered Harmful
Date: Wed, 1 Oct 2003 23:15:53 +0300 [thread overview]
Message-ID: <20031001201552.GR729@actcom.co.il> (raw)
In-Reply-To: <20031001151011.GL31698@wohnheim.fh-wedel.de>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Wed, Oct 01, 2003 at 05:10:11PM +0200, J?rn Engel wrote:
> > > --- a/include/linux/mm.h 28 Sep 2003 04:06:20 -0000 1.5
> > > +++ b/include/linux/mm.h 1 Oct 2003 13:15:53 -0000
> > > @@ -196,7 +196,7 @@ struct page {
> > > #if defined(WANT_PAGE_VIRTUAL)
> > > void *virtual; /* Kernel virtual address (NULL if
> > > not kmapped, ie. highmem) */
> > > -#endif /* CONFIG_HIGMEM || WANT_PAGE_VIRTUAL */
> > > +#endif /* CONFIG_HIGHMEM || WANT_PAGE_VIRTUAL */
> > > };
> >
> > This is broken, the CONFIG_HIG(H)MEM shouldn't be there at all. Look
> > at the #if defined(...) line.
[snipped]
Looks like this patch made it past Linus's famous patch barriers and
into the bk tree after all. J?rn, I trust you'll send a patch to
revert it? (Linus, if you want to fix it by hand, just deleted the
CONFIG_HIGHMEM bit completely from the #endif line).
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-10-01 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 13:26 [PATCH] CONFIG_* In Comments Considered Harmful Matthew Wilcox
2003-10-01 14:19 ` Dave Jones
2003-10-01 14:29 ` Valdis.Kletnieks
2003-10-01 14:42 ` Jörn Engel
2003-10-01 14:49 ` Matthew Wilcox
2003-10-01 14:41 ` Muli Ben-Yehuda
2003-10-01 14:39 ` Jörn Engel
[not found] ` <20031001145206.GH29313@actcom.co.il>
2003-10-01 15:10 ` Jörn Engel
2003-10-01 20:15 ` Muli Ben-Yehuda [this message]
2003-10-01 20:27 ` Linus Torvalds
2003-10-01 14:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001201552.GR729@actcom.co.il \
--to=mulix@mulix.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.