From: "David S. Miller" <davem@redhat.com>
To: Burton Windle <bwindle@fint.org>
Cc: netdev@oss.sgi.com
Subject: Re: [RFC] Silencing needless printk in socket.c
Date: Thu, 2 Oct 2003 01:48:38 -0700 [thread overview]
Message-ID: <20031002014838.0c790cda.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0310011429190.1125@morpheus>
On Wed, 1 Oct 2003 14:41:09 -0400 (EDT)
Burton Windle <bwindle@fint.org> wrote:
> Would anyone object to a patch that wraps the printk in
> linux/net/socket.c:1897 in a 'if debug'?
>
> This first appeared around 2.6.0-test5; the output may be helpful to a
> developer, but I don't think it is needed in the normal dmesg.
Yes it is needed, and since in the same changes that _ADDED_
this new printk I _REMOVED_ all the numerous per-protocol printks
that were printed out.
Less stuff is printed out now than before, and now this is the
only indication that a particular protocol family got registered
or unregistered successfully.
We're not removing this. This is especially the case beause people
like you didn't complain at all when we used to get 4 or 5 lines of
printk messages for each of these protocols when they started up or
shut down.
prev parent reply other threads:[~2003-10-02 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 18:41 [RFC] Silencing needless printk in socket.c Burton Windle
2003-10-02 8:48 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031002014838.0c790cda.davem@redhat.com \
--to=davem@redhat.com \
--cc=bwindle@fint.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.