From: Pavel Machek <pavel@ucw.cz>
To: paul.devriendt@amd.com, davej@redhat.com,
kernel list <linux-kernel@vger.kernel.org>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>
Subject: powernow-k8: don't crash system at boot
Date: Sun, 5 Oct 2003 21:00:57 +0200 [thread overview]
Message-ID: <20031005190056.GA863@elf.ucw.cz> (raw)
Hi!
powernow-k8 module fails to initialize government on boot, leading to
nasty crash at boot.
This fixes it. Plus find_closest_find really wants to be static. Fix
it, too.
Pavel
Index: arch/i386/kernel/cpu/cpufreq/powernow-k8.c
===================================================================
RCS file: /home/pavel/sf/bitbucket/bkcvs/linux-2.5/arch/i386/kernel/cpu/cpufreq/powernow-k8.c,v
retrieving revision 1.2
diff -u -u -r1.2 powernow-k8.c
--- arch/i386/kernel/cpu/cpufreq/powernow-k8.c 1 Oct 2003 17:33:23 -0000 1.2
+++ arch/i386/kernel/cpu/cpufreq/powernow-k8.c 5 Oct 2003 18:41:50 -0000
@@ -718,7 +718,7 @@
/* Converts a frequency (that might not necessarily be a multiple of 200) */
/* to a fid. */
-u32
+static u32
find_closest_fid(u32 freq, int searchup)
{
if (searchup == SEARCH_UP)
@@ -971,6 +971,7 @@
pol->cpuinfo.max_freq = 1000 * find_freq_from_fid(ppst[numps-1].fid);
pol->min = 1000 * find_freq_from_fid(ppst[0].fid);
pol->max = 1000 * find_freq_from_fid(ppst[batps - 1].fid);
+ pol->governor = CPUFREQ_DEFAULT_GOVERNOR;
printk(KERN_INFO PFX "cpu_init done, current fid 0x%x, vid 0x%x\n",
currfid, currvid);
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next reply other threads:[~2003-10-05 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-05 19:00 Pavel Machek [this message]
2003-10-07 16:03 ` powernow-k8: don't crash system at boot Dave Jones
2003-10-07 16:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031005190056.GA863@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.devriendt@amd.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.