All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>,
	irda-users@lists.sourceforge.net, netdev@oss.sgi.com
Subject: Re: [PATCH] (1/11) Irda dongle module owner support
Date: Mon, 6 Oct 2003 16:23:34 -0700	[thread overview]
Message-ID: <20031006232334.GA9277@bougret.hpl.hp.com> (raw)
In-Reply-To: <20031002152026.4bfd2c67.shemminger@osdl.org>

On Thu, Oct 02, 2003 at 03:20:26PM -0700, Stephen Hemminger wrote:
> IRDA dongle interface needed to be converted to have an owner field
> to avoid races on module unload.
> 
> Eliminated the use of hashbin locking because the dongle control
> code needed to do it's own locking to avoid races.   This also closed
> the race between find and insert. 
> 
> The find/insert hashbin race may be a general problem with all the IRDA
> hashbin stuff. IMHO the hashbin stuff should be replaced, it is full
> of dead incomplete code and done better by the list macros.

	Hi,

	More testing on 2.6.0-test6-bk8 on my SMP box...
	After modprobing irport, a modprobe of the actisys module
hangs forever.

	Conditions : irport was not yet attached/up. I had irdadump
running and an irda-usb active, and I had just rmmod sir_dev.
	I can see that modprobe is taking 100% cpu :
---------------------------------------
 1786 pts/1    R      4:11 modprobe actisys
---------------------------------------
	I can't kill it !
	No messages in the log.
---------------------------------------
# cat /proc/modules 
actisys 4032 1 - Loading 0xd0859000
irport 12672 0 - Live 0xd0884000
irda 182260 5 actisys,irport,irnet,irda_usb, Live 0xd08d3000
---------------------------------------

	After a clean reboot, I just tried to modprobe actisys even
before modprobing irport. Same result :
--------------------------------
# cat /proc/modules 
actisys 4032 1 - Loading 0xd0859000
irda 182260 1 actisys, Live 0xd08d3000
--------------------------------

	Any tip for debugging that ?

	Thanks...

	Jean

      parent reply	other threads:[~2003-10-06 23:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-02 22:20 [PATCH] (1/11) Irda dongle module owner support Stephen Hemminger
2003-10-02 23:33 ` Jean Tourrilhes
2003-10-03 17:21   ` [PATCH] (1/11) Irda dongle module owner support (revised) Stephen Hemminger
2003-10-03 17:31     ` Jean Tourrilhes
2003-10-04  6:06     ` David S. Miller
2003-10-03 13:55 ` [PATCH] (1/11) Irda dongle module owner support David S. Miller
2003-10-06 23:23 ` Jean Tourrilhes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031006232334.GA9277@bougret.hpl.hp.com \
    --to=jt@bougret.hpl.hp.com \
    --cc=davem@redhat.com \
    --cc=irda-users@lists.sourceforge.net \
    --cc=jt@hpl.hp.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.