From: "David S. Miller" <davem@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: netdev@oss.sgi.com
Subject: Re: tunnel xmit and h.raw
Date: Tue, 7 Oct 2003 08:32:37 -0700 [thread overview]
Message-ID: <20031007083237.1de6e10a.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0310030252070.1394-100000@u.domain.uli>
On Fri, 3 Oct 2003 03:00:27 +0300 (EEST)
Julian Anastasov <ja@ssi.bg> wrote:
> # --------------------------------------------
> # 03/10/03 ja@ssi.bg 1.1357
> # [IPV4/IPV6]: tunnel xmit must load skb->h.raw after all reallocations
> # --------------------------------------------
I've applied this, it is absolutely correct.
While studying this I've discovered some deeper problems.
The skb_shared() checks in these tunnel drivers is bogus,
on transmit skb->users should never ever be anything but 1.
Besides the tunnel drivers, the loopback driver and ipmr.c
do similar things in their ->hard_start_xmit() handlers.
In particular, the ipmr.c case is really in bad shape.
I've put fixing this onto the todo list...
prev parent reply other threads:[~2003-10-07 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 0:00 tunnel xmit and h.raw Julian Anastasov
2003-10-03 14:30 ` David S. Miller
2003-10-03 14:56 ` Julian Anastasov
2003-10-03 15:04 ` David S. Miller
2003-10-03 15:05 ` David S. Miller
2003-10-03 15:49 ` Mika Penttilä
2003-10-07 15:32 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007083237.1de6e10a.davem@redhat.com \
--to=davem@redhat.com \
--cc=ja@ssi.bg \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.