From: Matthew Wilcox <willy@debian.org>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Andries Brouwer <aebr@win.tue.nl>, Andrew Morton <akpm@osdl.org>,
"Sharma, Arun" <arun.sharma@intel.com>,
linux-kernel@vger.kernel.org, Matthew Wilcox <willy@debian.org>
Subject: Re: [PATCH] incorrect use of sizeof() in ioctl definitions
Date: Wed, 8 Oct 2003 14:30:17 +0100 [thread overview]
Message-ID: <20031008133017.GG10906@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <571ACEFD467F7749BC50E0A98C17CDD8F3283C@pdsmsx403.ccr.corp.intel.com>
On Wed, Oct 08, 2003 at 05:58:53PM +0800, Tian, Kevin wrote:
> Well, I may misunderstand the measurement here. By previous comment from
> Matthew Wilcox, I see "Clearly it's too late to change the ioctl
> definitions...". Er, so all things like IOR_BAD and size_t are just to
> keep current API untouched, while warning subsequent guys right way to
> populate ioctls. :) Then the last question is: is it worthy of some
> efforts to modify these APIs completely? Maybe the bee just bites
> once...
Already done on i386 and some other platforms. Not on ia64 yet, I see.
The bad_ioctl stuff is part of that typechecking.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-10-08 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 9:58 [PATCH] incorrect use of sizeof() in ioctl definitions Tian, Kevin
2003-10-08 13:30 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-08 11:42 Tian, Kevin
2003-10-08 13:33 ` Matthew Wilcox
2003-10-08 8:40 Tian, Kevin
2003-10-08 10:01 ` Maciej Zenczykowski
2003-09-30 20:53 Arun Sharma
2003-09-30 21:08 ` Andrew Morton
2003-09-30 21:35 ` Russell King
2003-09-30 21:43 ` Andrew Morton
2003-09-30 22:27 ` Maciej Zenczykowski
2003-09-30 22:25 ` Matthew Wilcox
2003-10-01 0:32 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008133017.GG10906@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=arun.sharma@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.