All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Andre Hedrick <andre@linux-ide.org>
Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	lkcd-devel@lists.sourceforge.net,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] Poll-based IDE driver
Date: Wed, 8 Oct 2003 17:48:51 +0100	[thread overview]
Message-ID: <20031008164851.GT29736@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10310080935350.7858-100000@master.linux-ide.org>

On Wed, Oct 08, 2003 at 09:36:36AM -0700, Andre Hedrick wrote:
 > 
 > Does not matter, priority is to get content to platter and the hell with
 > everything else.

I don't buy this. Without correct udelay()'s, how is code like this..

        for (i = 0; i < 10; i++) {
                dump_udelay(1);
                if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad))
                        return 0;
        } 

expected to work ? It won't wait for 10usec at all, but be over almost instantly.
Ramming commands at the drive before its status has settled doesn't strike
me as a particularly safe thing to do.

		Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk

  reply	other threads:[~2003-10-08 16:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17  9:11 [PATCH] Poll-based IDE dump driver for LKCD Srivatsa Vaddagiri
2003-09-17 13:55 ` Alan Cox
2003-10-08  9:43   ` [PATCH] Poll-based IDE driver Srivatsa Vaddagiri
2003-10-08 11:50     ` Dave Jones
2003-10-08 12:14       ` Srivatsa Vaddagiri
2003-10-08 12:15         ` Dave Jones
2003-10-08 13:26         ` Russell King
2003-10-08 18:34         ` [lkcd-devel] " Stephen Hemminger
2003-10-08 21:48         ` Alan Cox
2003-10-08 23:43           ` Jamie Lokier
2003-10-08 16:36       ` Andre Hedrick
2003-10-08 16:48         ` Dave Jones [this message]
2003-10-09  6:57           ` Andre Hedrick
2003-10-08 21:47     ` Alan Cox
2003-10-09  7:06       ` Andre Hedrick
2003-10-13 17:41         ` PRD Table id ol
2003-10-15 20:46           ` Alan Cox
2003-10-16 11:47           ` Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031008164851.GT29736@redhat.com \
    --to=davej@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andre@linux-ide.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcd-devel@lists.sourceforge.net \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.