Re: [PATCH] laptop mode

[Jens Axboe <axboe@suse.de>]

On Thu, Oct 09 2003, Dave Jones wrote:
> On Thu, Oct 09, 2003 at 04:05:47PM +0200, Jens Axboe wrote:
> 
>  > > Red Hat just dropped this patch since it was suspected of data 
>  > > corruption ;-(
>  > Eh? Care to explain a bit further? I'm not aware of any data corruption
>  > issues there, and it's certainly simple enough to easily audit.
> 
> 3-4 cases of random data corruption, all using Quantum Fireball drives,
> all with different IDE chipsets.
> 
>  > And how kind of Red Hat to not inform me of any suspicion in this
>  > regard.
> 
> I want to get facts right before crying wolf.

Fair enough.

> Right now laptopmode/aam is just a suspect. There are still 1-2 other
> small patches against IDE which could be the reason.  We've dropped
> laptopmode/aam for the time being to see if the folks seeing repeatable
> corruption suddenly start behaving again.

aam patch is far more risky, it's a far more likely suspect. That patch
never reall did go out of beta. Dropping laptop-mode and aam at the same
time is bad engineering practice :).

laptop-mode cannot cause corruption that cannot show otherwise.

-- 
Jens Axboe