From: Paul Mundt <lethal@linux-sh.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sunrpc/clnt.c compile fix
Date: Thu, 9 Oct 2003 12:40:48 -0400 [thread overview]
Message-ID: <20031009164048.GA12029@linux-sh.org> (raw)
In-Reply-To: <shsr81mnz8i.fsf@charged.uio.no>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Thu, Oct 09, 2003 at 12:37:49PM -0400, Trond Myklebust wrote:
> > This is due to the fact that tk_pid is protected by
> > RPC_DEBUG. Wrapping through dprintk() fixes this.
>
> No... You are suppressing legitimate warning messages that inform the
> user of a client/server mismatch!
>
> Better then to remove the tk_pid from the warning messages...
>
Is there any reason why tk_pid needs to be under RPC_DEBUG in the first place?
If these are legitimate warning messages, presumably it would be nice to know
the offending pid as well.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-10-09 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 16:13 [PATCH] net/sunrpc/clnt.c compile fix Paul Mundt
2003-10-09 16:33 ` Geert Uytterhoeven
2003-10-09 16:37 ` Trond Myklebust
2003-10-09 16:40 ` Paul Mundt [this message]
2003-10-09 16:50 ` Trond Myklebust
2003-10-09 16:54 ` Paul Mundt
2003-10-09 16:57 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009164048.GA12029@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.