From: Dave Jones <davej@redhat.com>
To: Nuno Monteiro <nmonteiro@uk2.net>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] Re: linking problem with 2.6.0-test6-bk10
Date: Fri, 10 Oct 2003 01:55:22 +0100 [thread overview]
Message-ID: <20031010005521.GC25856@redhat.com> (raw)
In-Reply-To: <20031010004224.GH4683@hobbes.itsari.int>
On Fri, Oct 10, 2003 at 01:42:24AM +0100, Nuno Monteiro wrote:
> Got 5 minutes to look at this today, here is the proper fix. This allows
> to compile for Winchip when CONFIG_MTRR is off. The alternative would be
> to pull in asm/mtrr.h and asm/errno.h, but it seems a bit overkill since
> we only need mtrr_centaur_report_mcr.
>
> Booted and working fine here on my small gateway box for the past hour.
> Please apply.
>
> +#ifndef CONFIG_MTRR
> +static __inline__ void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) {;}
> +#endif
> +
As well as looking pretty ugly, I can't convince myself this is safe.
I think it's going to be better off making that whole code compile out
if MTRRs are disabled. MTRR is a must-have if we want this code to actually
work anyway.
Either change the ifdef at the top of centaur.c to
#ifdef CONFIG_X86_OOSTORE && CONFIG_MTRR, or futz around it in the
Kconfig, by changing the X86_OOSTORE depends line to
depends on (MWINCHIP3D || MWINCHIP2 || MWINCHIPC6) && MTRR
Dave
--
Dave Jones http://www.codemonkey.org.uk
next prev parent reply other threads:[~2003-10-10 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 18:32 linking problem with 2.6.0-test6-bk10 Nuno Monteiro
2003-10-08 20:04 ` Dave Jones
2003-10-08 21:18 ` Nuno Monteiro
[not found] ` <20031009234000.GC4683@hobbes.itsari.int>
[not found] ` <20031010004047.GE4683@hobbes.itsari.int>
2003-10-10 0:42 ` [PATCH] " Nuno Monteiro
2003-10-10 0:55 ` Dave Jones [this message]
2003-10-10 1:42 ` Nuno Monteiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031010005521.GC25856@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nmonteiro@uk2.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.