All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: lm-sensors@vger.kernel.org
Subject: [PATCH] i2c-sis630 fixes for 2.6.0-test7
Date: Thu, 19 May 2005 06:24:20 +0000	[thread overview]
Message-ID: <20031010171552.GC16612@kroah.com> (raw)
In-Reply-To: <200310101904.19719.amalysh@web.de>

On Fri, Oct 10, 2003 at 07:04:18PM +0200, Alexander Malysh wrote:
> Hi Greg,
> 
> attached you can find a patch that should fix i2c-sis630 driver for 2.6.0-X 
> kernel. With i2c-sis630 from stock 2.6.0-X we have oops and driver was not 
> correct registered against i2c-core.
> 
> Changes:
> 	1) fixed a oops while modprobing
> 	2) added check for buffer overflow for i2c block data read transaction
> 	3) added 'force' modprobe parameter. It's allow more easily testing for not 
> yet supported SiS chips.
> 
> Please apply... Thanks.

Why did you add a printk() call right before a call to dev_err()?  Can
you remove that change and resubmit the patch?

thanks,

greg k-h

  reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:24 [PATCH] i2c-sis630 fixes for 2.6.0-test7 Alexander Malysh
2005-05-19  6:24 ` Greg KH [this message]
2005-05-19  6:24 ` Alexander Malysh
2005-05-19  6:24 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031010171552.GC16612@kroah.com \
    --to=greg@kroah.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.