From: "David S. Miller" <davem@redhat.com>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: netdev@oss.sgi.com, dmerillat@sequiam.com
Subject: Re: [RFT] Re: Fw: Nasty Oops in 2.6.0-test6 bind/SO_REUSEADDR
Date: Sat, 11 Oct 2003 12:56:56 -0700 [thread overview]
Message-ID: <20031011125656.322bd0ab.davem@redhat.com> (raw)
In-Reply-To: <20031010154052.GA11366@conectiva.com.br>
On Fri, 10 Oct 2003 12:40:52 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
> ipv6_rcv_saddr_equal, look at this:
>
> if (sk2->sk_family == AF_INET6 &&
> !ipv6_addr_cmp(&np->rcv_saddr,
> (sk2->sk_state != TCP_TIME_WAIT ?
> &inet6_sk(sk2)->rcv_saddr :
> &tcptw_sk(sk)->tw_v6_rcv_saddr)))
> ^^
> ^^
> shouldn't the tcp_tw_sk(sk) be tcp_tw_sk(sk2)?
Yes.
> And in this function we have the guard against it being a tcp_tw_bucket, but
> not in all places...
It does guard in this spot, that's why it is checking the
sk_state value.
prev parent reply other threads:[~2003-10-11 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 20:33 Fw: Nasty Oops in 2.6.0-test6 bind/SO_REUSEADDR David S. Miller
2003-10-09 17:03 ` Dan Merillat
2003-10-10 2:36 ` Arnaldo Carvalho de Melo
2003-10-10 3:22 ` [RFT] " Arnaldo Carvalho de Melo
2003-10-10 4:14 ` David S. Miller
2003-10-10 15:40 ` Arnaldo Carvalho de Melo
2003-10-11 19:56 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031011125656.322bd0ab.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=dmerillat@sequiam.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.