From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263288AbTJKOAF (ORCPT ); Sat, 11 Oct 2003 10:00:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263307AbTJKOAF (ORCPT ); Sat, 11 Oct 2003 10:00:05 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:5800 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S263288AbTJKOAC (ORCPT ); Sat, 11 Oct 2003 10:00:02 -0400 Date: Sat, 11 Oct 2003 15:59:43 +0200 From: Jens Axboe To: Pavel Machek Cc: Dave Jones , Jeff Garzik , marcelo.tosatti@cyclades.com, Linux Kernel Mailing List Subject: Re: [PATCH] laptop mode Message-ID: <20031011135943.GB1107@suse.de> References: <200310091103.h99B31ug014566@hera.kernel.org> <3F856A7E.2010607@pobox.com> <20031009140547.GD1232@suse.de> <20031009141734.GB23545@redhat.com> <20031009142632.GI1232@suse.de> <20031011114913.GA516@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031011114913.GA516@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 11 2003, Pavel Machek wrote: > Hi! > > > > Right now laptopmode/aam is just a suspect. There are still 1-2 other > > > small patches against IDE which could be the reason. We've dropped > > > laptopmode/aam for the time being to see if the folks seeing repeatable > > > corruption suddenly start behaving again. > > > > aam patch is far more risky, it's a far more likely suspect. That patch > > never reall did go out of beta. Dropping laptop-mode and aam at the same > > time is bad engineering practice :). > > > > laptop-mode cannot cause corruption that cannot show otherwise. > > Well, if fireballs have data-corrupting that happens just after spinup > (for example), I can see how laptop-mode affects that. W/o > laptop-mode, disk is spinning all the time so sleep bugs can not > manifest themselves. You add laptop-mode, and... Not very likely, imho. People have been using spin down with hdparm for years (in Linux and elsewhere), while acoustic management is a bit more esoteric. -- Jens Axboe