From: jbarnes@sgi.com (Jesse Barnes)
To: Jens Axboe <axboe@suse.de>
Cc: William Lee Irwin III <wli@holomorphy.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: I/O errors in -test7-mm1 tree on ia64
Date: Fri, 17 Oct 2003 15:15:25 -0700 [thread overview]
Message-ID: <20031017221525.GA8348@sgi.com> (raw)
In-Reply-To: <20031017101357.GE1128@suse.de>
On Fri, Oct 17, 2003 at 12:13:57PM +0200, Jens Axboe wrote:
> > --- fs/xfs/pagebuf/page_buf.c 2003-10-17 12:11:30.000000000 +0200
> > +++ fs/xfs/pagebuf/page_buf.c~ 2003-10-17 12:11:19.000000000 +0200
> > @@ -1406,10 +1406,8 @@
> > int cmd = WRITE;
> > if (pb->pb_flags & PBF_READ)
> > cmd = READ;
> > -#if 0
> > else if (pb->pb_flags & PBF_FLUSH)
> > cmd = WRITESYNC;
> > -#endif
> > submit_bio(cmd, bio);
> > if (size)
> > goto next_chunk;
> >
> > it was a mistake to enable barriers unconditionally on XFS when it has
> > no fallback logic. If you apply the above on test7-mm1, it should work
> > fine for you.
>
> Patch is reversed, you need to use -R. Funky.
That did the trick. Thanks.
Jesse
prev parent reply other threads:[~2003-10-17 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-16 18:55 I/O errors in -test7-mm1 tree on ia64 Jesse Barnes
2003-10-16 19:49 ` William Lee Irwin III
2003-10-16 20:46 ` Jesse Barnes
2003-10-17 10:12 ` Jens Axboe
2003-10-17 10:13 ` Jens Axboe
2003-10-17 22:15 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031017221525.GA8348@sgi.com \
--to=jbarnes@sgi.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.