From: William Lee Irwin III <wli@holomorphy.com>
To: Thomas Giese <Thomas.Giese@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test8-microcode
Date: Sat, 18 Oct 2003 08:26:42 -0700 [thread overview]
Message-ID: <20031018152642.GJ25291@holomorphy.com> (raw)
In-Reply-To: <008c01c39588$9b6f7650$fb457dc0@tgasterix>
On Sat, Oct 18, 2003 at 05:00:44PM +0200, Thomas Giese wrote:
> IA32 microcode fails in compile, in test7 it does not :
> linux:/mnt/hdb1/linux-2.6.0-test8 # make
> SPLIT include/linux/autoconf.h -> include/config/*
> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
> CHK include/linux/compile.h
> CC [M] arch/i386/kernel/microcode.o
> arch/i386/kernel/microcode.c: In function `find_matching_ucodes':
> arch/i386/kernel/microcode.c:328: parse error before `int'
> arch/i386/kernel/microcode.c:329: `ext_tablep' undeclared (first use in this
> fun
> ction)
> arch/i386/kernel/microcode.c:329: (Each undeclared identifier is reported
> only o
> nce
> arch/i386/kernel/microcode.c:329: for each function it appears in.)
> make[1]: *** [arch/i386/kernel/microcode.o] Error 1
> make: *** [arch/i386/kernel] Error 2
Hmm, you're supposed to declare variables before any code appears in C.
Maybe all this C99 stuff is turning it into C++.
-- wli
diff -prauN linux-2.6.0-test8/arch/i386/kernel/microcode.c microcode-2.6.0-test8-1/arch/i386/kernel/microcode.c
--- linux-2.6.0-test8/arch/i386/kernel/microcode.c 2003-10-17 14:42:56.000000000 -0700
+++ microcode-2.6.0-test8-1/arch/i386/kernel/microcode.c 2003-10-18 08:21:06.000000000 -0700
@@ -323,9 +323,10 @@ static int find_matching_ucodes (void)
memcpy(newmc, &mc_header, MC_HEADER_SIZE);
/* check extended table checksum */
if (ext_table_size) {
+ int *ext_tablep;
int ext_table_sum = 0;
i = ext_table_size / DWSIZE;
- int * ext_tablep = (((void *) newmc) + MC_HEADER_SIZE + data_size);
+ ext_tablep = (((void *) newmc) + MC_HEADER_SIZE + data_size);
while (i--) ext_table_sum += ext_tablep[i];
if (ext_table_sum) {
printk(KERN_WARNING "microcode: aborting, bad extended signature table checksum\n");
prev parent reply other threads:[~2003-10-18 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-18 15:00 2.6.0-test8-microcode Thomas Giese
2003-10-18 15:22 ` 2.6.0-test8-microcode Tigran Aivazian
2003-10-18 15:26 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031018152642.GJ25291@holomorphy.com \
--to=wli@holomorphy.com \
--cc=Thomas.Giese@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.