All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: an7 <an3h0ny@yahoo.fr>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: Useless networking code in 2.4.x ?
Date: Thu, 23 Oct 2003 03:31:00 -0700	[thread overview]
Message-ID: <20031023033100.1bc47d31.davem@redhat.com> (raw)
In-Reply-To: <20031023085801.40580.qmail@web11105.mail.yahoo.com>

On Thu, 23 Oct 2003 10:58:01 +0200 (CEST)
an7 <an3h0ny@yahoo.fr> wrote:

> If we have a look at tcp_recv_skb, and
> tcp_read_sock(),
>
> we notice that there is a SYN check, and if the flag
> is on, we do offset-- (sequence number not
> corresponding to real data byte). 
>
> This Syn check is useless, as the function cannot be
> called at the beginning of a connection (since we have
> not copied_seq filled with the last sequence number of
> the last packet passed to the upper layer)
> 
> What do you think of that ?

Please next time, take this kind of question to netdev@oss.sgi.com
where the networking developers are, most of them are not subscribed
to linux-kernel.

As to your question, if we ever support accepting data in the
initial final SYN-ACK packet, this code would be needed, so it's
better to keep this code around.


      reply	other threads:[~2003-10-23 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-23  8:58 Useless networking code in 2.4.x ? an7
2003-10-23 10:31 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031023033100.1bc47d31.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=an3h0ny@yahoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.