From: Pavel Machek <pavel@ucw.cz>
To: John Mock <kd6pag@qsl.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Kill unneccessary debug printk
Date: Fri, 24 Oct 2003 01:34:53 +0200 [thread overview]
Message-ID: <20031023233453.GA847@elf.ucw.cz> (raw)
In-Reply-To: <E1ACnDZ-0005GV-00@penngrove.fdns.net>
Hi!
> > Actually, that 'printk' is useful. As i understand it, the only way software
> > suspend is going to work is that if the same video mode is used on resume as
> > on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate
> > a proper string for 'lilo -R' (which i already do to make sure the correct
> > kernel gets resumed during testing). If i'm mistaken about needing to set
> > VGA mode identically on resume, then i have no objection to removing the
> > printk.
>
> Oops, someone is using my debug printk :-(. I'll at least try
> to merge it with some other msg, so it does not waste full
> line.
>
> Better yet, let's take this opportunity to do this more cleanly. How
> about having something like /sys/power/vmode (or /proc/...) contain that
> inforemation instead? With luck, it might even be few kernel bytes than
> the original printk (or at least not much more). (I know nothing about
> either /proc or /sys, so it would take me awhile to suggest a patch).
Well, you probably know about as much as I do. I'm afraid I'm just
going to take the easy way out.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-10-23 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-23 21:42 Kill unneccessary debug printk John Mock
2003-10-23 23:34 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-20 18:05 John Mock
2003-10-23 20:00 ` Pavel Machek
2003-10-20 17:07 Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031023233453.GA847@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=kd6pag@qsl.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.