From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263019AbTJZMI1 (ORCPT ); Sun, 26 Oct 2003 07:08:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263052AbTJZMI0 (ORCPT ); Sun, 26 Oct 2003 07:08:26 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:8457 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S263019AbTJZMIP (ORCPT ); Sun, 26 Oct 2003 07:08:15 -0500 Date: Sun, 26 Oct 2003 12:08:08 +0000 From: Russell King To: Adrian Bunk Cc: Andrew Morton , suparna@in.ibm.com, daniel@osdl.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, pbadari@us.ibm.com Subject: Re: Patch for Retry based AIO-DIO (Was AIO and DIOtestingon2.6.0-test7-mm1) Message-ID: <20031026120808.D25595@flint.arm.linux.org.uk> Mail-Followup-To: Adrian Bunk , Andrew Morton , suparna@in.ibm.com, daniel@osdl.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, pbadari@us.ibm.com References: <20031021121113.GA4282@in.ibm.com> <1066869631.1963.46.camel@ibm-c.pdx.osdl.net> <20031023104923.GA11543@in.ibm.com> <20031023135030.GA11807@in.ibm.com> <20031023155937.41b0eeda.akpm@osdl.org> <20031023232006.GH21490@fs.tum.de> <20031023162539.0051249d.akpm@osdl.org> <20031023233700.GJ21490@fs.tum.de> <20031023164638.5c32b80f.akpm@osdl.org> <20031026115719.GA10333@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20031026115719.GA10333@fs.tum.de>; from bunk@fs.tum.de on Sun, Oct 26, 2003 at 12:57:19PM +0100 X-Message-Flag: Your copy of Microsoft Outlook is vulnerable to viruses. See www.mutt.org for more details. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 26, 2003 at 12:57:19PM +0100, Adrian Bunk wrote: > On Thu, Oct 23, 2003 at 04:46:38PM -0700, Andrew Morton wrote: > >... > > > -Os has it's benefits on some systems, so it shouldn't be totally hidden > > > under EMBEDDED. OTOH, it's less tested, so only people who know what > > > they are doing should use it (EXPERIMENTAL plus help text). > > > > It causes kernels to crash on a major linux distribution. We need to > > either make it very hard to turn on, or just forget it altogether. > > The -Os patch with a dependency on EMBEDDED is below. > > diffstat output: > > arch/arm/Makefile | 2 -- > arch/h8300/Kconfig | 4 ++++ > arch/h8300/Makefile | 2 +- > Makefile | 8 +++++++- > init/Kconfig | 10 ++++++++++ > 5 files changed, 22 insertions(+), 4 deletions(-) So now ARM goes back to not building with -Os. Maybe the right answer is to completely forget about making this a configuration-time option for 2.6? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core