Re: [PATCH] Fix ip_queue for bridged packets

["David S. Miller" <davem@redhat.com>]

On Sat, 25 Oct 2003 17:09:13 +0200
Bart De Schuymer <bdschuym@pandora.be> wrote:

> When ip_queue copies an old skbuff to a new one (because the tailroom is
> too small), it uses skb_copy_expand(). This function doesn't copy the
> Ethernet header, which is not needed for normal IP traffic. Normally, the
> Ethernet header is filled in later before doing dev_queue_xmit.
> When ip_queue does this to a bridged IP packet, it has to copy the Ethernet
> header, because the Ethernet header is already filled in and won't be filled
> in again.
> The patch below makes this happen. It puts the code that actually copies the
> header inside netfilter_bridge.h, so that it can be reused and altered
> without touching other code.
> 
> The patch is already approved by Stephen Hemminger (in private mail).
> Since Harald Welte excels in silence, I'm sending netfilter stuff directly
> to you from now on.

I thought we were taking care of this stuff via other means?

This problem feels like an old one to me, and it's why we added all
the bridge netfilter objects to struct sk_buff, right?  Why doesn't
that take care of this instance of the problem?