From: "David S. Miller" <davem@redhat.com>
To: Georg Chini <georg.chini@triaton-webhosting.com>
Cc: rezso@rdsor.ro, sparclinux@vger.kernel.org,
netfilter-devel@lists.netfilter.org
Subject: Re: iptables+2.6-test8-bk4 : Still problems
Date: Tue, 28 Oct 2003 22:48:03 -0800 [thread overview]
Message-ID: <20031028224803.1d16aa9c.davem@redhat.com> (raw)
In-Reply-To: <3F9ED206.4040806@triaton-webhosting.com>
On Tue, 28 Oct 2003 21:31:02 +0100
Georg Chini <georg.chini@triaton-webhosting.com> wrote:
> David S. Miller wrote:
> > It's some bug in the translation code in net/compat.c
>
> Yes it is.
> The problem is, that the ipt_entries are not all the same
> size. So instead of copying them one by one you have
> to copy the whole block. Here is a patch:
Good spotting, I didn't know this.
However, I was trying to avoid a kmalloc of anything in this code :(
You're also not verifying the kmalloc() return value for errors.
I think I'll use copy_in_user() to fix this bug, thanks.
next prev parent reply other threads:[~2003-10-29 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 8:48 iptables+2.6-test8-bk4 : Still problems Georg Chini
2003-10-26 15:52 ` Balint Cristian
2003-10-27 6:34 ` David S. Miller
2003-10-28 20:31 ` Georg Chini
2003-10-29 6:48 ` David S. Miller [this message]
2003-10-29 7:13 ` David S. Miller
2003-10-29 18:20 ` Ryan Veety
2003-10-29 18:34 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031028224803.1d16aa9c.davem@redhat.com \
--to=davem@redhat.com \
--cc=georg.chini@triaton-webhosting.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rezso@rdsor.ro \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.