From: Andrew Sharp <andy@ccpu.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Bryan Henderson <hbryan@us.ibm.com>,
Matthew Wilcox <willy@debian.org>,
Peter Braam <braam@clusterfs.com>,
intermezzo-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] remove TCGETS
Date: Tue, 28 Oct 2003 15:51:47 -0800 [thread overview]
Message-ID: <20031028235147.GA29213@ccpu.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0310281303190.1600-100000@home.osdl.org>
On Tue, Oct 28, 2003 at 01:07:53PM -0800, Linus Torvalds wrote:
>
> On Tue, 28 Oct 2003, David Woodhouse wrote:
> >
> > Linus; executive decision required please:
>
> I don't know you you _require_ an executive decision, but the simple fact
> is that the regular Linux ioctl() handler always returns ENOTTY if it
> doesn't match a ioctl number. See fs/ioctl.c.
>
> In short, the way I think this should be handled is:
> - if you don't recognize the ioctl, you should return ENOTTY
> - if you recognize the ioctl, but some parameter to the ioctl is wrong,
> you should return EINVAL.
>
> This is consistent with file_ioctl(), and also consistent with traditional
> uses of ENOTTY. It also just happens to make LTP pass, but I will leave to
> you to make up your own mind on whether that is because LTP is a good
> test, or whether it's just a small unimportant detail.
Can't we add the range of tty ioctls to file_ioctl so that it can return
ENOTTY so each and every file system driver doesn't have to?
a
next prev parent reply other threads:[~2003-10-28 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 21:48 [PATCH] remove TCGETS Matthew Wilcox
2003-08-12 21:59 ` Andreas Dilger
2003-08-13 1:42 ` Peter Braam
2003-08-13 12:12 ` David Woodhouse
2003-08-13 15:35 ` Andreas Dilger
2003-08-14 1:28 ` Peter Braam
2003-08-14 1:43 ` Matthew Wilcox
2003-08-14 15:54 ` Bryan Henderson
2003-10-28 15:56 ` David Woodhouse
2003-10-28 19:41 ` Bryan Henderson
2003-10-28 20:52 ` Andries Brouwer
2003-10-28 21:07 ` Linus Torvalds
2003-10-28 23:51 ` Andrew Sharp [this message]
2003-10-29 1:54 ` Linus Torvalds
2003-10-29 0:46 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031028235147.GA29213@ccpu.com \
--to=andy@ccpu.com \
--cc=braam@clusterfs.com \
--cc=dwmw2@infradead.org \
--cc=hbryan@us.ibm.com \
--cc=intermezzo-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.