[PATCH/RFT] check non-scsi part of status in scsi_status_is_good

[Patrick Mansfield <patmans@us.ibm.com>]

Ronald can you test this out, and send usb storage logs?

For your device I assume we will now send a MODE SENSE page 0x0 that will
get a bogus ILLEGAL REQUEST, but then the following MODE SENSE page 0x3f
with a longer length might work.

I test booted, but do not have any removable media or USB storage
attached.

----------------

Only the scsi status byte is being checked for all callers of
scsi_status_is_good. This means non-scsi errors are treated as no error at
all without this fix.

diff -uprN -X /home/patman/dontdiff bl-25/include/scsi/scsi.h status-fix-bl-2.5/include/scsi/scsi.h
--- bl-25/include/scsi/scsi.h	Mon Sep 29 12:21:10 2003
+++ status-fix-bl-2.5/include/scsi/scsi.h	Wed Oct 29 07:19:56 2003
@@ -126,6 +126,8 @@ extern const unsigned char scsi_command_
  */
 static inline int scsi_status_is_good(int status)
 {
+	if (status & 0xffffff00)
+		return 0;
 	/*
 	 * FIXME: bit0 is listed as reserved in SCSI-2, but is
 	 * significant in SCSI-3.  For now, we follow the SCSI-2

-- Patrick Mansfield