From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Michael Clark <michael@metaparadigm.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.0-test9 Fix oops in quirk_via_bridge
Date: Fri, 31 Oct 2003 09:49:46 +0000 [thread overview]
Message-ID: <20031031094946.A4556@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3FA22E6F.8000404@metaparadigm.com>; from michael@metaparadigm.com on Fri, Oct 31, 2003 at 05:42:07PM +0800
On Fri, Oct 31, 2003 at 05:42:07PM +0800, Michael Clark wrote:
> Strangely making the quirk and its data __devinit solves the problem
> (as is most of the other stuff in pci/quirks.c). Not sure if it is
> the correct fix but it works for me. ie. why did I get the oops
> in the first place? as the quirks data was global and not marked
> for an __init section.
The function was marked as __init. I'd strongly recommend against
marking the data with __devinitdata since its used elsewhere in the
kernel by non-init code.
> --- linux-2.6.0-test9/drivers/pci/quirks.c 2003-10-31 16:49:25.000000000 +0800
> +++ linux-2.6.0-test9-mc/drivers/pci/quirks.c 2003-10-31 16:49:57.000000000 +0800
> @@ -644,9 +644,9 @@
> * VIA northbridges care about PCI_INTERRUPT_LINE
> */
>
> -int interrupt_line_quirk;
> +__devinitdata int interrupt_line_quirk;
>
> -static void __init quirk_via_bridge(struct pci_dev *pdev)
> +static void __devinit quirk_via_bridge(struct pci_dev *pdev)
> {
> if(pdev->devfn == 0)
> interrupt_line_quirk = 1;
>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2003-10-31 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-31 9:42 [PATCH] 2.6.0-test9 Fix oops in quirk_via_bridge Michael Clark
2003-10-31 9:49 ` Russell King [this message]
2003-10-31 9:58 ` Michael Clark
2003-10-31 10:00 ` Russell King
2003-10-31 10:37 ` Michael Clark
2003-11-07 17:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031031094946.A4556@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@metaparadigm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.