From: Andrew Morton <akpm@osdl.org>
To: Daniele Venzano <webvenza@libero.it>
Cc: mochel@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add PM support to sis900 network driver
Date: Mon, 3 Nov 2003 12:06:47 -0800 [thread overview]
Message-ID: <20031103120647.549f0c81.akpm@osdl.org> (raw)
In-Reply-To: <20031103181721.GC852@picchio.gall.it>
Daniele Venzano <webvenza@libero.it> wrote:
>
> On Sun, Nov 02, 2003 at 11:12:54AM -0800, Andrew Morton wrote:
> > pci_set_power_state() can sleep, so we shouldn't be calling it
> > under spin_lock_irqsave(). Is it necessary to hold the lock
> > here?
>
> New patch with locking completely removed, since in a similar
> function none was used.
OK. I think. Net driver suspend handlers in general seem a bit racy wrt
interrupt activity as well as SMP. Maybe I'm missing something.
> I think also the 8139too driver has the same locking problem in
> rtl8139_suspend, do you want a patch ?
Wouldn't hurt, thanks. It's one way to wake Jeff up ;)
8139too just does netif_device_detach(), whereas your sis900 patch does
netif_stop_queue() and then netif_device_detach().
I don't know which is right, really. 8139too will end up with a
non-stopped queue if __LINK_STATE_PRESENT is clear. The sis900 approach is
certainly safe enough, but it'd be nice to know what netif_device_detach()
is trying to do there.
next prev parent reply other threads:[~2003-11-03 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-02 18:28 [PATCH] Add PM support to sis900 network driver Daniele Venzano
2003-11-02 19:12 ` Andrew Morton
2003-11-02 19:16 ` Daniele Venzano
2003-11-03 18:17 ` Daniele Venzano
2003-11-03 20:06 ` Andrew Morton [this message]
2003-11-03 22:46 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031103120647.549f0c81.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=webvenza@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.