From: Sam Ravnborg <sam@ravnborg.org>
To: Olaf Hering <olh@suse.de>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] incorrect function declaration for claim()
Date: Thu, 6 Nov 2003 23:31:16 +0100 [thread overview]
Message-ID: <20031106223116.GA1790@mars.ravnborg.org> (raw)
In-Reply-To: <20031106202445.GA6293@suse.de>
On Thu, Nov 06, 2003 at 09:24:45PM +0100, Olaf Hering wrote:
> +++ linux-2.4/arch/ppc/boot/chrp/main.c 2003-11-06 21:21:26.000000000 +0100
> @@ -17,7 +17,7 @@ extern char _start, _end;
>
> extern int getprop(void *, const char *, void *, int);
> extern unsigned int heap_max;
> -extern void claim(unsigned int virt, unsigned int size, unsigned int align);
> +extern void *claim(unsigned int virt, unsigned int size, unsigned int align);
> extern void *finddevice(const char *);
> extern void flush_cache(void *, unsigned long);
> extern void gunzip(void *, int, unsigned char *, int *);
In general I consider it a bug to have prototypes in a .c file....
Sam
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2003-11-06 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-06 20:24 [PATCH] incorrect function declaration for claim() Olaf Hering
2003-11-06 22:31 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031106223116.GA1790@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.