From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: Neil Brown <neilb@cse.unsw.edu.au>, Andrew Morton <akpm@osdl.org>,
Burton Windle <bwindle@fint.org>,
Linux-kernel@vger.kernel.org
Subject: Re: slab corruption in test9 (NFS related?)
Date: Mon, 10 Nov 2003 05:56:04 +0000 [thread overview]
Message-ID: <20031110055603.GF7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0311092007451.3002-100000@home.osdl.org>
On Sun, Nov 09, 2003 at 08:09:40PM -0800, Linus Torvalds wrote:
>
> On Mon, 10 Nov 2003, Neil Brown wrote:
> >
> > An extra dput was introduced in nfsd_rename 20 months ago....
> >
> > time to remove it.
>
> Oh, you stand-up comedian you.
>
> I'm just wondering how the hell this hasn't bit us seriously until now?
> What's up?
>
> In other words, your patch certainly looks obviously correct, but it also
> looks _so_ obviously correct that my alarm bells are going off. If the
> code was quite that broken at counting dentries, how the hell did it ever
> work AT ALL?
>
> Call me suspicious, but I find this really strange..
Arrgh...
No, Neil is right - it was a plain and simple fsckup on my part. No hidden
logics is there; his fix is correct.
prev parent reply other threads:[~2003-11-10 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-09 23:16 slab corruption in test9 (NFS related?) Burton Windle
2003-11-10 3:04 ` Andrew Morton
2003-11-10 3:05 ` Neil Brown
2003-11-10 4:09 ` Linus Torvalds
2003-11-10 4:23 ` Joshua Kwan
2003-11-10 4:36 ` Trond Myklebust
2003-11-10 4:42 ` Linus Torvalds
2003-11-10 4:36 ` Neil Brown
2003-11-10 4:45 ` Linus Torvalds
2003-11-10 4:51 ` Andrew Morton
2003-11-10 5:56 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031110055603.GF7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=Linux-kernel@vger.kernel.org \
--cc=akpm@osdl.org \
--cc=bwindle@fint.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.