Re: LKCD Network dump over netpoll patch (2.6.0-test9)

[Matt Mackall <mpm@selenic.com>]

On Mon, Nov 10, 2003 at 07:37:42PM +0530, Prasanna S Panchamukhi wrote:
> Hi,
> 

Hi.

> +		put_unaligned(htonl(reply.nr), (u32 *) (tmp_membuf + 1));
> +		put_unaligned(htonl(reply.code), (u32 *) (tmp_membuf + 5));
> +		put_unaligned(htonl(reply.info), (u32 *) (tmp_membuf + 9));
> +
> +		memcpy((tmp_membuf + HEADER_LEN), buff + offset, 1024);
> +		netpoll_send_udp(np, tmp_membuf, (1024 + HEADER_LEN));

There's quite a few instances of this header business, it could really
stand to be in its own netdump_send(nr, code, info, data) function.

> -			dump_ndev->poll_controller(dump_ndev);
> +			netpoll_poll(&net_dev->np);
>  			zap_completion_queue();
...
> +void zap_completion_queue(void);

Instead of this (missing netpoll_, btw), how about we call
zap_completion_queue inside of netpoll_poll?

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting