From: "David S. Miller" <davem@redhat.com>
To: Jack Steiner <steiner@sgi.com>
Cc: davidm@hpl.hp.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Inefficient TLB flushing
Date: Wed, 12 Nov 2003 19:56:01 -0800 [thread overview]
Message-ID: <20031112195601.6c9b718d.davem@redhat.com> (raw)
In-Reply-To: <20031112200119.GA22429@sgi.com>
On Wed, 12 Nov 2003 14:01:19 -0600
Jack Steiner <steiner@sgi.com> wrote:
> --- /usr/tmp/TmpDir.19957-0/linux/mm/memory.c_1.79 Wed Nov 12 13:56:25 2003
> +++ linux/mm/memory.c Wed Nov 12 12:57:25 2003
> @@ -574,9 +574,10 @@
> if ((long)zap_bytes > 0)
> continue;
> if (need_resched()) {
> + int fullmm = (*tlbp)->fullmm;
> tlb_finish_mmu(*tlbp, tlb_start, start);
> cond_resched_lock(&mm->page_table_lock);
> - *tlbp = tlb_gather_mmu(mm, 0);
> + *tlbp = tlb_gather_mmu(mm, fullmm);
> tlb_start_valid = 0;
> }
> zap_bytes = ZAP_BLOCK_SIZE;
This patch looks perfectly fine, good analysis.
next prev parent reply other threads:[~2003-11-13 3:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 20:01 Inefficient TLB flushing Jack Steiner
2003-11-12 20:49 ` David Mosberger
2003-11-12 21:22 ` Andrew Morton
2003-11-13 3:18 ` Jack Steiner
2003-11-13 3:31 ` Andrew Morton
2003-11-13 3:56 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-11-12 20:01 Jack Steiner
2003-11-12 20:49 ` David Mosberger
2003-11-12 21:22 ` Andrew Morton
2003-11-13 3:18 ` Jack Steiner
2003-11-13 3:31 ` Andrew Morton
2003-11-13 3:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031112195601.6c9b718d.davem@redhat.com \
--to=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.